Update cloneBlock and replaceBlock to use XML api instead of string search/replace #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the fonction gave by brad-jones on the issue : PHPOffice#341 (comment)
Take lot of time and not necessary if you well form your template
|
Hello, Do we have a chance to get the PR merged ? What is needed to go ahead ? |
|
This fix helped me lot. But not understanding why this is not yet merged. |
johnnymallie
added a commit
to webadev/PHPWord
that referenced
this pull request
Mar 14, 2017
|
Love the code, it uses SimpleXMLElement/xpath however, how does findBlock do it when there are multiple blocks named the same? would it get the first open and last close block? Also, why not implement it as a subclass of TemplateProcessor, this way, it can live side-by-side with the original TemplateProcessor. You also need some testcases to make the code maintainable later on. You should update your code to force Scrutinizer/Travis do a recheck. As it is now, red, you make less chance to merge it in. |
2 tasks
troosan
changed the title
Progi1984
force-pushed
the
master
branch
3 times, most recently
from
2d9f999
to
e458249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the fonction gave by @brad-jones on the issue :
#341 (comment)