Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified for adding compatible objects #511

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

adiabvs
Copy link

@adiabvs adiabvs commented Mar 25, 2015

Issue - OLEobject creation not done properly and hopefully we cannot do. so we can embed object as package.

Because of xls, doc, and ppt types are not packages they are Removed.

Now we can add object of type xlsx,docx and pptx through addObject.

@troosan
Copy link
Contributor

troosan commented Dec 6, 2017

indeed, you are right.
But with this fix you broke the behaviour for the "old" xls, doc and ppt.
I'll try to see if we cannot support both format, and maybe also pdf as requested in #1141

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to complete the PR by adding tests and making sure that the CI is green.
Thank you for your contributions.

@github-actions github-actions bot added the Stale label Nov 18, 2022
@Progi1984 Progi1984 removed the Stale label Nov 18, 2022
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants