Bugfix for #383: Strange behavior of cloneRow with multiple tables #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a check for the end of table, for correct processing of multiple tables with spanned rows
|
May be @RomanSyroeshko could take a look to this ? |
|
@scmember Can you close this pull request, problem has been identified and I have a patch request ready. Your proposal for a fix is not quite correct, it would match MSWord docx documents, but not LibreOffice docx documents due to them not having extra spaces just before a close ( Because of this, tables made with OpenOffice would never match and go outside the table. Making cloneRow() not that useful when w:vMerge was encountered. Superseded by #1147 |
|
@FBnil agree, close this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for the end of table, for correct processing of multiple tables with spanned rows