addHTML fixes for PHP 5.3 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated the test for addHTML to include some common html entities, quoted text and ampersand. |
Adding some HTML Entities to the test for addHTML
|
Thanks @bskrtich. I'll merge this ASAP. |
ivanlanin
added a commit
that referenced
this pull request
Jun 10, 2014
ghost
mentioned this pull request
|
Is this issue of embedded & definitely fixed as we're having issues with it, I've had to convert them to ' and ' in order to get the doc generated? We're Using 0.12.0 of phpword and PHP 5.3.10. It doesn't matter if we use htmlspecialchars or not, we pass it in correctly as '& ;' (without the space) and what gets outputted to the file is '&'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found 2 bugs with the addHTML function. One when running under PHP 5.3 the default character encoding is ISO-8859-1 (This was changed to UTF-8 in PHP 5.4) which causes loadXML to hork because of it converts things like & nbsp ; to non-valid UTF-8 characters. The second is when you try to use an ampersand in the html you are trying to convert to docx.