Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevented fatal errors when opening corrupt files or "doc" files #2626

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mmcev106
Copy link

@mmcev106 mmcev106 commented Jun 19, 2024

Description

This prevents fatal exceptions when trying to load corrupt files or old "doc" files, allowing applications to catch the exception and fail gracefully.

Fixes # (issue) - None. I just fixed it without reporting an issue.

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@mmcev106
Copy link
Author

I'm looking into the coding standard failures.

@coveralls
Copy link

Coverage Status

coverage: 97.209% (+0.001%) from 97.208%
when pulling d6a2106 on mmcev106:master
into 2daa50c on PHPOffice:master.

@coveralls
Copy link

Coverage Status

coverage: 97.209% (+0.001%) from 97.208%
when pulling d6a2106 on mmcev106:master
into 2daa50c on PHPOffice:master.

@coveralls
Copy link

Coverage Status

coverage: 97.209% (+0.001%) from 97.208%
when pulling d6a2106 on mmcev106:master
into 2daa50c on PHPOffice:master.

@mmcev106
Copy link
Author

I think we're good to go now (guessing the deploy failure is not something I should look into).

@mmcev106
Copy link
Author

@everaldofilho, thanks for the approval. Any idea when this might get merged? If there are any further changes you'd like me to make, please ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants