Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Processor Persist File After Destruct #2545

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

oleibman
Copy link
Contributor

@oleibman oleibman commented Jan 8, 2024

Description

Replace PR #2542.

Fix #2539. Inadvertent break in TemplateProcessor behavior after #2475. Deleted temp file on destruct. It will now persist after destructor.

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

Replace PR PHPOffice#2542.

Fix PHPOffice#2539. Inadvertent break in TemplateProcessor behavior after PHPOffice#2475. Deleted temp file on destruct. It will now persist after destructor.
@coveralls
Copy link

coveralls commented Jan 8, 2024

Coverage Status

coverage: 97.217% (-0.001%) from 97.218%
when pulling 8cb119f on oleibman:nounlink3
into 98d038e on PHPOffice:master.

@Progi1984 Progi1984 added this to the 2.0.0 milestone Jan 8, 2024
@Progi1984 Progi1984 merged commit 41cf4eb into PHPOffice:master Jan 8, 2024
13 checks passed
@Progi1984
Copy link
Member

Thanks @oleibman for your contribution

@kevinpapst
Copy link

Thanks for tackling the issue 👍

@oleibman oleibman deleted the nounlink3 branch January 10, 2024 03:22
@Maybe-U
Copy link

Maybe-U commented Jan 10, 2024

Thanks @oleibman for your contribution
please review my code thanks a lot
#2547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] TemplateProcessor behavior changed with 1.2 - temporary file gets deleted while still being used
5 participants