Update Html.php to enable choice of leading method. #2379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current loadXML() rejects valid self-closing elements from HTML. The problem can be fixed in a backwards compatible way by adding a new boolean argument to choose which loading method to use.
Description
Self-closing tags like
<br>
and<img>
are valid in HTML but not in XML. Loading the DOM via loadHTML() solves the current problem with the static function addHtml(). Since the loading method is a choice that depends on the caller, a new boolean argument is added to control which method will be used, defaulting to the current behaviour which is to use loadXML().Fixes # (issue)
Checklist:
composer run-script check --timeout=0
and no errors were reported