styleid also for other Elements #2360
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all other types like paragraphs and characters should also receive a styleid. We will set this like the stylename. Otherwise it could be misleading for some converters or readers, which work with the styleid, like for example GemBox. Microsoft Word itself does also set IDs for all other elements like characters. We had issues when setting fonts via $phpword->addFontStyle() which lead to not producing a styleid in the word\styles.xml and GemBox showed all content of the document in the same default font style.
Progi1984
force-pushed
the
master
branch
3 times, most recently
from
2d9f999
to
e458249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All other types like paragraphs and characters should also receive a styleid. We will set this like the stylename. Otherwise it could be misleading for some converters or readers, which work with the styleid, like for example GemBox. Microsoft Word itself does also set IDs for all other elements like characters.
We had issues when setting fonts via $phpword->addFontStyle() which lead to not producing a styleid in the word\styles.xml and GemBox showed all content of the document in the same default font style.
Checklist:
composer run-script check --timeout=0and no errors were reported