Add Support for Various Missing Features in HTML Writer #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR supersedes PHPOffice#1814, which had become badly out of sync due to recent changes to the repository. Implement a number of features implemented in PhpWord, but not yet supported in PhpWord HTML Writer. 1. Use css @page and page declarations for sections. 2. Wrap sections in div, with page break before each (except first). 3. Add ability to specify generic fallback font for html (documentation change). 4. Add ability to specify handling of whitespace in html (documentation change). Currently, Word writer preserves space but HTML writer does not. 5. Support for Language, both for document overall and individual text elements. 6. Support for PageBreak for HTML (currently only PDF is supported). 7. Support for Table Border style, color, and size. 8. Support for empty paragraphs (Word writer permits, browsers generally suppress). 9. Default paragraph style should apply to all paragraphs, as well as class Normal. 10. Paragraph style should support line-height. 11. Paragraph style should support indentation. 12. Paragraph style should support page-break-before. 13. Paragraph style should not specify margin-top/bottom when spacing is null.
Use deprecated assertRegExp if its replacement is not available.
Catch Throwable instead.
Simple changes to address its new issues.
3 tasks
|
@Progi1984 This is the rebased version you requested for 1814. It passes all existing and new unit tests, as well as some additional tests I made. |
It can run out of memory for large files, as in PhpSpreadsheet.
Restrict to PhpUnit 7, 8, or 9.
Try to satisfy Scrutinizer.
Very minor improvement.
Correct some problems.
... I hope.
See if it works.
Several minor fixes, mostly to tests.
Make sure it captures Warnings, Notices, Deprecations.
Use E_ALL for error_reporting.
It handles page breaks with a different non-standard extension than the other PDF products. Also honor user's choice of paper rather than hardcoding A4.
No vertical spacing between paragraphs when user has explicitly spaceBefore and spaceAfter to 0 in default paragraph style.
Use Vertical Spacing when default spaceBefore and spaceAfter are numeric, not just zero.
TCPDF does not parse any of the CSS margin properties. Text-indent can be used as an imperfect margin-left replacement.
I had put typehint for private variable in code rather than comment.
Little in common, clearer code afterwards.
Little in common, code is now clearer.
Ensure `isPdf` is set in constructor so that `getContent` will be correct.
Many uses, e.g. adding headers and footers in Mpdf.
Use defined constant to include headers and footers in initial WriteHTML.
Specify direction as rtl for font style when rtl is true, and for paragraph style when bidi is true.
Add to Shared/HTML, update Writer Html/Odt/Rtf appropriately.
Annotate some intended use of deprecations.
Not limited to Html/Pdf, some changes were needed for Rtf and Odt as well. Allow user to set default RTL setting applied to Paragraph, Font, and Table styles when they don't explicitly set a direction.
At least I hope it's momentary - couldn't initialize Php7.4 or 8.0, didn't attempt others.
2d9f999
to
e458249
Compare
oleibman
added a commit
to oleibman/PHPWord
that referenced
this pull request
Sep 18, 2023
This PR supersedes PHPOffice#1814 and PHPOffice#2343, which had become badly out of sync due to recent changes to the repository. Implement a number of features implemented in PhpWord, but not yet supported in PhpWord HTML Writer. 1. Use css @page and page declarations for sections. 2. Wrap sections in div, with page break before each (except first). 3. Add ability to specify generic fallback font for html (documentation change). 4. Add ability to specify handling of whitespace in html (documentation change). Currently, Word writer preserves space but HTML writer does not. 5. Support for Language, both for document overall and individual text elements. 6. Support for PageBreak for HTML (currently only PDF is supported). 7. Support for Table Border style, color, and size. 8. Support for empty paragraphs (Word writer permits, browsers generally suppress). 9. Default paragraph style should apply to all paragraphs, as well as class Normal. 10. Paragraph style should support line-height. 11. Paragraph style should support indentation. 12. Paragraph style should support page-break-before. 13. Paragraph style should not specify margin-top/bottom when spacing is null.
3 tasks
|
Superseded by #2475. |
Progi1984
pushed a commit
to oleibman/PHPWord
that referenced
this pull request
Nov 8, 2023
This PR supersedes PHPOffice#1814 and PHPOffice#2343, which had become badly out of sync due to recent changes to the repository. Implement a number of features implemented in PhpWord, but not yet supported in PhpWord HTML Writer. 1. Use css @page and page declarations for sections. 2. Wrap sections in div, with page break before each (except first). 3. Add ability to specify generic fallback font for html (documentation change). 4. Add ability to specify handling of whitespace in html (documentation change). Currently, Word writer preserves space but HTML writer does not. 5. Support for Language, both for document overall and individual text elements. 6. Support for PageBreak for HTML (currently only PDF is supported). 7. Support for Table Border style, color, and size. 8. Support for empty paragraphs (Word writer permits, browsers generally suppress). 9. Default paragraph style should apply to all paragraphs, as well as class Normal. 10. Paragraph style should support line-height. 11. Paragraph style should support indentation. 12. Paragraph style should support page-break-before. 13. Paragraph style should not specify margin-top/bottom when spacing is null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #1814, which had become badly out of sync due to recent changes to the repository.
Implement a number of features implemented in PhpWord, but not yet supported in PhpWord HTML Writer.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Checklist:
composer run-script check --timeout=0and no errors were reported