Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP7.1 (min.) #2302

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Support for PHP7.1 (min.) #2302

merged 1 commit into from
Sep 26, 2022

Conversation

Progi1984
Copy link
Member

Description

Support for PHP7.1 (min.)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@Progi1984 Progi1984 merged commit f92ec7e into PHPOffice:develop Sep 26, 2022
@Progi1984 Progi1984 deleted the php7.1+ branch September 26, 2022 06:52
@Progi1984 Progi1984 added the dependencies Pull requests that update a dependency file label Sep 26, 2022
@Progi1984 Progi1984 added this to the v0.19.0 milestone Sep 26, 2022
@PowerKiKi
Copy link
Member

Supporting old EOL PHP version goes against https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support and the recent #2297. This also hinder adoptions of new PHP features in our codebase (typehint would be extra-nice), and complexify the whole maintenance work.

Why did you need to add back support for very old EOL PHP versions ?

@Progi1984
Copy link
Member Author

@PowerKiKi The support that you share the link is about PhpSpreadsheet. I try for PhpWord & PhpPresentation to have the max support for it. My customers have this need and pay for this support.

PowerKiKi added a commit that referenced this pull request Oct 24, 2022
@PowerKiKi
Copy link
Member

PowerKiKi commented Oct 24, 2022

I was not aware you have customer paying for support of old PHP version. I restored a few more things via #2314.

I meant to release a 1.0.0, following b9f1151, to help folks in #2239. Also to clearly communicate that this project has been production ready for a very long time. And despite the roadmap to v1 being incomplete. Is that OK with you ?

Mon1k pushed a commit to Infowatch/PHPWord that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

None yet

2 participants