Allow to customize macro delimiters in TemplateProcessor #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismail1432
changed the title
ismail1432
changed the title
ismail1432
force-pushed
the
customize-macro
branch
4 times, most recently
from
4819f2b
to
7fb6f50
Compare
ismail1432
changed the title
ismail1432
force-pushed
the
customize-macro
branch
from
7fb6f50
to
fae44be
Compare
ismail1432
force-pushed
the
customize-macro
branch
2 times, most recently
from
8f0e81e
to
17f9692
Compare
|
💡 The code does not pass the CI checks, I will take a look to fix this |
ismail1432
force-pushed
the
customize-macro
branch
4 times, most recently
from
c4b226b
to
53c0700
Compare
ismail1432
force-pushed
the
customize-macro
branch
from
53c0700
to
c4bcba9
Compare
|
Friendly ping 👋 |
|
Sorry, any update on the ability to merge it? |
|
@Progi1984 🙏 ❤️ |
|
lgtm! succesfully using it in production. |
Progi1984
approved these changes
Dec 23, 2022
|
Thanks @ismail1432 |
We use this in production since 8 months 👌 Thanks for merging for this awesome library 🔥 |
|
Thanks @ismail1432 & @benconda for the contribution. Sorry for the time. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello 👋
Congratulations on this huge project 🔥
I'm glad to open a pull request with new additions where the goal is to allow developers to customize macros delimiters with 3 methods:
setMacroOpeningCharssetMacroClosingCharssetMacroCharsYou can see #2251 for more details.
💡 I ran
composer run-script check --timeout=0and got an output that is not related to the PR:CamelCasePropertyName The property $TOCStyle is not named in camelCase.✅ I duplicated all tests related to the TemplateProcessor with the customization of macros and it works like a charm.
I let you check the PR let me know if something is wrong or if you need more information.
Checklist:
composer run-script check --timeout=0and no errors were reported