Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add variable name on row clone exception message #2236

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Nicals
Copy link

@Nicals Nicals commented Jun 2, 2022

Description

When TemplateProcessor::cloneRow fails to find a variable, the exception message did tell which template variable wasn't found.
This PR add the variable name in the exception message to help debugging template.

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to complete the PR by adding tests and making sure that the CI is green.
Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 22, 2022
@github-actions github-actions bot removed the Stale label Sep 23, 2022
@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:08
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant