Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template processor hyperlinks #2228

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

velPL
Copy link

@velPL velPL commented May 18, 2022

Description

Added setHyperLink() method to Template Processor allowing to insert external hyperlinks.

Fixes #1887 #471

Additional info

  • I had to fix code of TOC element class due to phpmd checkup result
  • I have no clue what's the cause of code coverage upload error - glad to hear advice on how to fix that on my end

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@PongVL
Copy link

PongVL commented Jul 7, 2022

Hope this function can be merged to dev branch soon. We need it!

Respect output escaping being enabled when inserting hyperlink url into XML Relationship tag
@velPL
Copy link
Author

velPL commented Nov 7, 2022

Hello. Are there any chances of feedback/merge ?

@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:08
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants