Template processor - improve regex in replace block method #2216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request improve REGEX used in template processing (
TemplateProcessor
class) inreplaceBlock
method.The below example shows a case where a regular expression matches an incorrect piece of document content and after replacing causes an error during opening the file.
Current REGEX:
Proposed REGEX:
Example document content:
Current REGEX will result in below matches with is incorrect and lead to the wrong replacement:
REGEX proposed in this pull request correctly matches piece of code that should be replaced:
Checklist:
composer run-script check --timeout=0
and no errors were reported