Added configuration arguments for specifing the start and end tokens of macros in the template processor #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macros in the template processor
Progi1984
force-pushed
the
master
branch
3 times, most recently
from
2d9f999
to
e458249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we using a 'Word'-library but we wanted to switch to PHPWord. We wanted to switch to PHPWord. We are processing templates but our templates (20.000+) have other tokens to start and end the macros.
With this PR we want to add the posibility to make the start and end token configurable.
When the PHPWord team wants to accept this contribution we will update this PR with a documentation update.
Checklist:
composer run-script check --timeout=0and no errors were reported