Fix cloneBlock issue #2006
Open
Fix cloneBlock issue #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lexdewilligen is this issue still present in 0.18.0? |
|
@troosan I can confirm that the issue is still present with the latest release 0.18.2 This PR fixes the issue. Thank you @lexdewilligen ! |
Progi1984
force-pushed
the
master
branch
3 times, most recently
from
2d9f999
to
e458249
Compare
|
This doesn't always work. It breaks when the cloneBlock is around a table. It doesn't generate the values inside the block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The regex function in cloneBlock may be too complicated or result in too many matches. Therefore, it can occur that the function results in no matches and therefore doesn't replace any blocks. I've solved this issue by making the regex more precise (by adding an extra group) and this solves the issue. It could probably also be fixed by increasing one of these PHP configurations. This however is not what should be expected from users of this package.
Might fix many cloneBlock and replaceBlock issues
https://github.com/PHPOffice/PHPWord/issues?q=cloneBlock
https://github.com/PHPOffice/PHPWord/issues?q=replaceBlock