Ensure that entity_loader disable variable is re-set back to the orig… #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seamuslee001
force-pushed
the
libxml_improve
branch
from
0ad8244
to
27ee4be
Compare
|
ping @Progi1984 This is basically the same as #1585 |
troosan
reviewed
Mar 5, 2019
There was a problem hiding this comment.
ping @Progi1984 This is basically the same as #1585
what do you mean?
Sorry got my PRs mixed up it was this one PHPOffice/Common#29 |
…inal setting Simplify the setting of libxml_disable_entity_loader
seamuslee001
force-pushed
the
libxml_improve
branch
from
27ee4be
to
607378b
Compare
|
@troosan thanks for the pointer (once i finally understood it gahh) i have now updated the code to be as simple as possible i think so should be ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…inal setting
Description
I work for a project that implements PHPWord that being CiviCRM, we have found that the changes here have sometimes disrupted our test suite because we have used XML to define our menu structure and like. This is because the changes override the global value of the loading of external entites and doesn't re-set afterwards.
Checklist:
composer run-script check --timeout=0and no errors were reported