Fix ampersand corrupting document

[silverbackdan]

see: #1500

Description

This will replace any ampersand that is not already followed by a semi-colon (making it an HTML character) with &. This is because without converting it, the document cannot be opened.

Fixes #1500

Checklist:

• I have run composer run-script check --timeout=0 and no errors were reported
• The new code is covered by unit tests (check build/coverage for coverage report)
• n/a I have update the documentation to describe the changes

[silverbackdan]

FYI: PHP 5.3 test fails due to php running out of memory in travis during the composer install command.

[coveralls]

Coverage increased (+0.001%) to 94.839% when pulling 6245a42 on silverbackdan:patch-1 into 1876062 on PHPOffice:develop.

[troosan]

@silverbackdan wouldn't it be better to do this replacement when generating the document instead of when creating the Text element? What will happen when generating not a docx but an rtf document?

[margori]

Patch applied, bug not solved.
Suggest include test.

[troosan]

Actually, this is the intended behaviour (for backward compatibility reasons).
The get the result you want you have to call

Settings::setOutputEscapingEnabled(true);

[silverbackdan]

right ok, thanks for the additional info - I appreciate everyone's time in replying on this chain. Enjoy your week.