Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change regexp used in cloneBlock operation in TemplateProcessor #1497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change regexp used in cloneBlock operation in TemplateProcessor #1497

wants to merge 1 commit into from
+3 −3

Conversation

nlared
Copy link

@nlared nlared commented Nov 1, 2018

this fix replaceBlock

@nlared
Update TemplateProcessor.php
00d9509 
this fix replaceBlock
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.838% when pulling 00d9509 on nlared:patch-1 into 1876062 on PHPOffice:develop.

@troosan
Copy link
Contributor

troosan commented Dec 11, 2018

@nlared please provide unit test to describe the issue and prove your fix

@troosan troosan changed the title Update TemplateProcessor.php Change regexp used in cloneBlock operation in TemplateProcessor Dec 26, 2018
@troosan troosan added the Waiting for feedback Question has been asked, waiting for response from PR author label Dec 26, 2018
@troosan
Copy link
Contributor

troosan commented Dec 26, 2018

@ndench is this trying to fix the same as #1478 (which is fixing #1477)?

@ndench
Copy link
Contributor

ndench commented Jan 6, 2019

@troosan I'm not sure, that would be a question for @nlared or @babache.

@babache
Copy link

babache commented Jan 7, 2019 •
edited
Loading

use this https://pastebin.com/2YBKVj4m , I abandoned the idea with REGEX

@manukieli
Copy link

Thank you @babache, I had an issue with regex and this solution work perfect for me.

@matthieubarbaresco
Copy link

No blocks has been cloned in my template, with this code.

And no error, no exception.

@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:11
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
@curala70
Copy link

use this https://pastebin.com/2YBKVj4m , I abandoned the idea with REGEX

We had the same issue with PHPWord version 1.1.0. This solved our problem.
@babache Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Waiting for feedback Question has been asked, waiting for response from PR author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@nlared @coveralls @troosan @ndench @babache @manukieli @matthieubarbaresco @curala70