Improve docx parser to recognise style definition on Headings, which are overriding the default style #1470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inline style differences within headings can currently be missed when reading a docx file. For example, when a heading style is bold, but part of the heading text has been un-bolded. This change ensures that styling that is due to the heading style, is also set on individual Text elements within a TextRun, so they can be differentiated from any that are explicitly overridden.
Previously, all the Text elements within a TextRun that gets set on a Title element, just get the default Font element. That meant, for example, that
isBold()
returned false, whereas heading styles are often in bold.