Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading of w:drawing for documents produced by word 2011+ #1324

Merged
merged 5 commits into from
Jul 14, 2018

Conversation

troosan
Copy link
Contributor

@troosan troosan commented Mar 25, 2018

Description

Adds parsing of Word 2011 word documents. Images are put in w:drawing instead of w:pics
Continuation of #464, it's a start for issue #1312

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)

@troosan
Copy link
Contributor Author

troosan commented Mar 26, 2018

This cannot be merged yet as this branch is pointing to the dev version of PHPOffice/Common. PHPOffice/Common#17 needs to be released first.

@troosan troosan changed the title Parse drawings Support reading of w:drawing for documents produced by word 2011+ Mar 26, 2018
@davermn5
Copy link

@troosan

Hi Mr. Troostembergh,

I am badly in need of this feature. I am working on a project which needs to read the images from the ".docx" file.

And I do understand that the author of PHPOffice/Common ( @Progi1984 ) has not yet released version 0.2.8.

I'm willing to post a bounty or contribute a donation to this project if I have to. Just please message me or let me know if that is something we can work out.

Even if you could release a version of PHPWord which includes this feature, that would be satisfactory enough for my needs.

Thank you,
David

@troosan
Copy link
Contributor Author

troosan commented Jul 5, 2018

@davermn5 don't worry, php-common can be released.
I'll include the fix in the upcoming version

@troosan troosan added this to the v0.15.0 milestone Jul 14, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 94.839% when pulling de83da2 on troosan:parse_drawings into 6475812 on PHPOffice:develop.

@troosan troosan merged commit 9ee99d2 into PHPOffice:develop Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants