Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic version of Reader for Word2007 #104

Merged
merged 14 commits into from
Mar 12, 2014
Merged

Conversation

ivanlanin
Copy link
Contributor

The concept is to read the Word file and push the variables to the same containers that we use to write, i.e. Section, Paragraph, Font, etc. This is a very simple version of the Reader. Feel free to test, elaborate, or discuss the concept.

@ivanlanin
Copy link
Contributor Author

Small first step for #70 :)

@Progi1984 Progi1984 added this to the 0.7.7 milestone Mar 11, 2014
@Progi1984
Copy link
Member

@ivanlanin Don't forget unit tests for added code :)

@ivanlanin
Copy link
Contributor Author

Ok :)

@ivanlanin
Copy link
Contributor Author

Basic unit tests done. Passed all test and samples working.

I've also split TestHelperDOCX and XmlDocument for compliance with PSR.

@ivanlanin
Copy link
Contributor Author

Oh, by the way, forgive me for committing too many files with small code formatting changes. I can't stand reading too many errors reported by phpcs :)

@Progi1984
Copy link
Member

Do I let you this pull request opened for improving it ? or Do I merge it now ?

@ivanlanin
Copy link
Contributor Author

Later. Since I make a lot of code formatting changes, I'll merge everyone else pulls while doing some more code cleaning. I'll wait for you to merge the pull from bskrtich.

@ivanlanin
Copy link
Contributor Author

I'm done. Please merge.

Progi1984 added a commit that referenced this pull request Mar 12, 2014
Basic version of Reader for Word2007
@Progi1984 Progi1984 merged commit b58d1c8 into PHPOffice:develop Mar 12, 2014
@Progi1984 Progi1984 modified the milestones: 0.9.3, 0.9.5 Mar 14, 2014
@Progi1984 Progi1984 added this to the 0.8.0 milestone Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants