Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32-bit Error With PasswordEncoder #2550

Closed
oleibman opened this issue Jan 15, 2024 · 0 comments · Fixed by #2551
Closed

32-bit Error With PasswordEncoder #2550

oleibman opened this issue Jan 15, 2024 · 0 comments · Fixed by #2551
Labels
Bug Report

Comments

@oleibman
Copy link
Contributor

Describe the Bug

PasswordEncoder is not 32-bit safe. PasswordEncoderTest will fail ("Implicit conversion from float 4294967295 to int loses precision") when tested with a recent enough version of 32-bit Php. This will cause the test to error out. It is easily fixed, and a PR will be available within an hour. AFAIK, this is the only 32-bit problem in the codebase.

Steps to Reproduce

Run unit-test PasswordEncoderTest with a 32-bit version of Php

Expected Behavior

Test should succeed.

Current Behavior

What is the current behavior?
Test fails ("Implicit conversion from float 4294967295 to int loses precision").

Context

Please fill in your environment information:

  • PHP Version: 8.3, 8.2
  • PHPWord Version: any
oleibman added a commit to oleibman/PHPWord that referenced this issue Jan 15, 2024
@oleibman
Fix 32-bit Problem in PasswordEncoder
7e21348 
Fix PHPOffice#2550.
@Progi1984 Progi1984 mentioned this issue Jan 15, 2024
Merged
3 tasks
Progi1984 pushed a commit that referenced this issue Jan 23, 2024
@oleibman
Fix 32-bit Problem in PasswordEncoder (#2551)
8b891bb 
* Fix 32-bit Problem in PasswordEncoder

Fix #2550.

* Update change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 32-bit Problem in PasswordEncoder oleibman/PHPWord
1 participant
@oleibman