Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated: Implicit conversion from float 10.5 to int loses precision #2526

Closed
nudl3s opened this issue Dec 11, 2023 · 1 comment · Fixed by #2531
Closed

Deprecated: Implicit conversion from float 10.5 to int loses precision #2526

nudl3s opened this issue Dec 11, 2023 · 1 comment · Fixed by #2531
Labels
Bug Report

Comments

@nudl3s
Copy link

nudl3s commented Dec 11, 2023

Describe the Bug

My PHP version is 8.3. When I am trying to load some file gives me some warnings for deprecated code.

Steps to Reproduce

Please provide a code sample that reproduces the issue.

<?php
$phpWord = IOFactory::load($file, 'MsDoc');

Current Behavior

Deprecated: Implicit conversion from float 10.5 to int loses precision at PhpWord\Reader\MsDoc.php:1868
Deprecated: Creation of dynamic property PhpOffice\PhpWord\Shared\OLERead::$entry is deprecated (For all properties inside this file)

Context

Please fill in your environment information:

  • PHP Version: 8.3
  • PHPWord Version: 1.1.0

Possible solution

In MsDoc.php at line 1868, use (int) to cast the result of the division to an integer explicitly.
$oStylePrl->styleFont['size'] = dechex((int) ($operand / 2));

To fix the second type deprecations, declare the properties in the class instead of dynamically creating it.
@oleibman
Copy link
Contributor

The missing properties were defined in PR #2440, which has been merged but which is not yet part of a release (there is a beta release available which includes it).

oleibman added a commit to oleibman/PHPWord that referenced this issue Dec 17, 2023
@oleibman
Correct Font Size Calculated by MsDoc Reader
bf9e2b0 
Fix PHPOffice#2526. Most of that issue has already been fixed. The one remaining problem was a deprecation message handling font size. The code used `dechex($operand / 2)`, and issued the deprecation message whenever `$operand` was odd because `dechex` is designed only for integer conversion. `$operand` is actually 2 times the point size, so it will be odd only when the point size is some integer plus half a point (no other fractions are allowed). At any rate, it seems that `dechex` should not be used here in the first place; font size is a numeric value, not a hex string.

There are many problems with MsDoc Reader at the moment. This PR is narrowly focused on the problem at hand. Its test is, at least, more detailed than the existing MsDoc Reader test, which does nothing more than confirm that read successfully creates a PhpWord object. The new test verifies that the font size is as expected, but does not validate any other aspect of the read.
@oleibman oleibman mentioned this issue Dec 17, 2023
Merged
3 tasks
sibalonat pushed a commit to sibalonat/PHPWord that referenced this issue Jan 7, 2024
@oleibman @sibalonat
Correct Font Size Calculated by MsDoc Reader
447b3fd 
Fix PHPOffice#2526. Most of that issue has already been fixed. The one remaining problem was a deprecation message handling font size. The code used `dechex($operand / 2)`, and issued the deprecation message whenever `$operand` was odd because `dechex` is designed only for integer conversion. `$operand` is actually 2 times the point size, so it will be odd only when the point size is some integer plus half a point (no other fractions are allowed). At any rate, it seems that `dechex` should not be used here in the first place; font size is a numeric value, not a hex string.

There are many problems with MsDoc Reader at the moment. This PR is narrowly focused on the problem at hand. Its test is, at least, more detailed than the existing MsDoc Reader test, which does nothing more than confirm that read successfully creates a PhpWord object. The new test verifies that the font size is as expected, but does not validate any other aspect of the read.
Progi1984 added a commit that referenced this issue Jan 8, 2024
@sibalonat @oleibman
@dependabot @Progi1984
Added extractVariables method to IOFactory (#2515)
98d038e 
* Added extractVariables method to IOFactory

* remove var_dumps

* remove vardump

* fix return and fix php stan errors and instances

* fix order and whitespace

* extra space

* remove new lines

* white space

* new lines

* whiteline

* new line

* white space

* fix

* new line

* white space

* remove some unneecessary if statement

* Correct Font Size Calculated by MsDoc Reader

Fix #2526. Most of that issue has already been fixed. The one remaining problem was a deprecation message handling font size. The code used `dechex($operand / 2)`, and issued the deprecation message whenever `$operand` was odd because `dechex` is designed only for integer conversion. `$operand` is actually 2 times the point size, so it will be odd only when the point size is some integer plus half a point (no other fractions are allowed). At any rate, it seems that `dechex` should not be used here in the first place; font size is a numeric value, not a hex string.

There are many problems with MsDoc Reader at the moment. This PR is narrowly focused on the problem at hand. Its test is, at least, more detailed than the existing MsDoc Reader test, which does nothing more than confirm that read successfully creates a PhpWord object. The new test verifies that the font size is as expected, but does not validate any other aspect of the read.

* Suggestions from @Progi1984

* Typo Tolerated By Windows but Not By Unix

* Correct Title Line of Change Log

* Bump dompdf/dompdf from 2.0.3 to 2.0.4

Bumps [dompdf/dompdf](https://github.com/dompdf/dompdf) from 2.0.3 to 2.0.4.
- [Release notes](https://github.com/dompdf/dompdf/releases)
- [Commits](dompdf/dompdf@v2.0.3...v2.0.4)

---
updated-dependencies:
- dependency-name: dompdf/dompdf
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump phpunit/phpunit from 9.6.13 to 9.6.14

Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 9.6.13 to 9.6.14.
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/9.6.14/ChangeLog-9.6.md)
- [Commits](sebastianbergmann/phpunit@9.6.13...9.6.14)

---
updated-dependencies:
- dependency-name: phpunit/phpunit
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump mpdf/mpdf from 8.2.0 to 8.2.2

Bumps [mpdf/mpdf](https://github.com/mpdf/mpdf) from 8.2.0 to 8.2.2.
- [Release notes](https://github.com/mpdf/mpdf/releases)
- [Changelog](https://github.com/mpdf/mpdf/blob/development/CHANGELOG.md)
- [Commits](mpdf/mpdf@v8.2.0...v8.2.2)

---
updated-dependencies:
- dependency-name: mpdf/mpdf
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump phpmd/phpmd from 2.14.1 to 2.15.0

Bumps [phpmd/phpmd](https://github.com/phpmd/phpmd) from 2.14.1 to 2.15.0.
- [Release notes](https://github.com/phpmd/phpmd/releases)
- [Changelog](https://github.com/phpmd/phpmd/blob/master/CHANGELOG)
- [Commits](phpmd/phpmd@2.14.1...2.15.0)

---
updated-dependencies:
- dependency-name: phpmd/phpmd
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

* Bump phpunit/phpunit from 9.6.14 to 9.6.15

Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 9.6.14 to 9.6.15.
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/9.6.15/ChangeLog-9.6.md)
- [Commits](sebastianbergmann/phpunit@9.6.14...9.6.15)

---
updated-dependencies:
- dependency-name: phpunit/phpunit
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

* Bump symfony/process from 5.4.28 to 5.4.34

Bumps [symfony/process](https://github.com/symfony/process) from 5.4.28 to 5.4.34.
- [Release notes](https://github.com/symfony/process/releases)
- [Changelog](https://github.com/symfony/process/blob/7.0/CHANGELOG.md)
- [Commits](symfony/process@v5.4.28...v5.4.34)

---
updated-dependencies:
- dependency-name: symfony/process
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

* Added extractVariables method to IOFactory

* remove var_dumps

* fix return and fix php stan errors and instances

* fix order and whitespace

* remove new lines

* white space

* new lines

* whiteline

* new line

* white space

* fix

* white space

* remove some unneecessary if statement

* variable changes

* 2.0.0 md

* 2.0.0

* new line at end of the file

* add entry to md

* additional space, type fixes in enhancement md and iofactory

* some fixes on spacing

* based on fixer suggestions

* new line at the end of the file

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: oleibman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Progi1984 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct Font Size Calculated by MsDoc Reader oleibman/PHPWord
2 participants
@oleibman @nudl3s