#2187 Addresses deprecation on PHP 8.1 in ZipArchi #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for merging. Is there a timeline for a tagged release please? :) |
|
It's been released as https://github.com/PHPOffice/PHPWord/releases/tag/0.18.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses the deprecation in PHP 8.1 noted in issue #2187.
The fix does not break backwards compatibility because existing code can still pass no second argument (or pass explicitly pass
null) and existing behaviour will not be affected.Fixes #2187
Checklist:
composer run-script check --timeout=0and no errors were reportedI didn't add any new tests. There is already a test which tests calling
PhpOffice\PhpWord\Shared\ZipArchive::open()with no second arg passed (i.e.nullpassed). The version of phpunit in the project means I can't run the test suite locally to verify that the 8.1 deprecation has been fixed.I'm also not able to run the composer script because
composer installinstalled an old version of phpunit that won't run on PHP 8.