-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation on PHP 8.1 in ZipArchive #2187
Labels
Comments
3 tasks
PowerKiKi
added a commit
that referenced
this issue
Feb 17, 2022
#2187 Addresses deprecation on PHP 8.1 in ZipArchi
I just wanted to thank you for your great work. So, thank you in the name of everyone who uses PHPWord and are migrating to PHP 8.1 |
3 tasks
glady
pushed a commit
to glady/PHPWord
that referenced
this issue
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current method signature of
ZipArchive::open()
ispublic function open($filename, $flags = null)
.If no argument is passed as the second argument here,
null
is passed as the second argument on line 136:Passing
0
achieves the same behaviour as passingnull
. Therefore, I believe the appropriate fix here would be:This would eliminate the deprecation and not break any BC within the library.
I'm happy to submit a PR if required.
The text was updated successfully, but these errors were encountered: