-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strikethrough font style in Word2007 does not work #1722
Labels
Milestone
Comments
mussbach
added a commit
to mussbach/PHPWord
that referenced
this issue
Aug 18, 2021
As stated in PHPOffice#1722 and PHPOffice#1693 `setPairedVal` sets DoubleStrikethrough to false which does not equal `null` This change may somehow infer with 54e7c6d but as no tests could be found it is hard to say what would possibly break
Any news on that issue ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's not possible to use strike font style with Word2007 writer because it uses strict comparison. Methods
isStrikethrough
andisDoubleStrikethrough
can returntrue
,false
ornull
,false !== null
.src/PhpWord/Writer/Word2007/Style/Font.php
You cannot use elements
w:strike
andw:dstrike
in same time. When you set strike style to true eg. withsetStrikethrough
then it calls methodsetPairedVal
that should disable double strike style.src/PhpWord/Style/Font.php
src/PhpWord/Style/AbstractStyle.php
In the writer the method
$style->isDoubleStrikethrough() !== null
evaluates astrue
even when this method returnsfalse
. Please note that methodsetPairedVal
sets this value tofalse
.The text was updated successfully, but these errors were encountered: