Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are drawing shape feature? #123

Closed
jhfangying opened this issue Mar 14, 2014 · 8 comments
Closed

There are drawing shape feature? #123

jhfangying opened this issue Mar 14, 2014 · 8 comments
Assignees
Milestone

Comments

@jhfangying
Copy link
Contributor

I found code "if ($this->getDrawingHashTable()->getByIndex($i) instanceof PHPWord_Shape_Drawing)" in ODText.php ,but i didn't find class PHPWord_Shape_Drawing .I don‘t know how to use it.

@ivanlanin
Copy link
Contributor

I think it's a legacy code from PHPExcel. I haven't found it used in any part of the code. The code coverage report of the unit tests didn't show it's use either. There are other parts of the PHPWord that I haven't find used, e.g.:

  • HashTable.php
  • Shared\ZipStreamWrapper.php

I think they are also come from PHPExcel.

@jhfangying
Copy link
Contributor Author

Does it mean I can not use PHPWord drawing shape?

2014-03-14 13:43 GMT+08:00 Ivan Lanin [email protected]:

I think it's a legacy code from PHPExcel. I haven't found it used in any
part of the code. The code coverage report of the unit tests didn't show
it's use either. There are other parts of the PHPWord that I haven't find
used, e.g.:

  • HashTable.php
  • Shared\ZipStreamWrapper.php

I think they are also come from PHPExcel.

¡ª
Reply to this email directly or view it on GitHubhttps://github.com//issues/123#issuecomment-37618509
.

ÎÒÊÔÊÔÇ©Ãû

@ivanlanin
Copy link
Contributor

No. You can't draw shapes with PHPWord 0.7. Perhaps with 1.0? :)

@Progi1984 Progi1984 added this to the 0.7.4 milestone Mar 14, 2014
@Progi1984
Copy link
Member

@jhfangying @ivanlanin I confirm... it's a part from PHPExcel that I haven't removed.
For the support of drawing shape, it's an enhancement. 😉

@ivanlanin ivanlanin modified the milestones: 2.0.0, 1.0.0, Later Apr 13, 2014
@ivanlanin ivanlanin self-assigned this Jun 1, 2014
ivanlanin added a commit to ivanlanin/PHPWord that referenced this issue Jun 2, 2014
ivanlanin added a commit that referenced this issue Jun 2, 2014
New drawing shapes (arc, curve, line, polyline, rect, oval) for #123
@ivanlanin
Copy link
Contributor

Hi @jhfangying. It's now possible to create drawing shapes (arc, curve, line, polyline, rect, oval). Please get the latest code from the develop branch. See and run Sample_31_Shape.php on the samples folder. Thanks.

@ivanlanin ivanlanin modified the milestones: 0.12.0, Later Jun 2, 2014
@jhfangying
Copy link
Contributor Author

That's greate,thank you!

2014-06-03 0:01 GMT+08:00 Ivan Lanin [email protected]:

Hi @jhfangying https://github.com/jhfangying. It's now possible to
create drawing shapes (arc, curve, line, polyline, rect, oval). Please get
the latest code from the develop branch. See and run Sample_31_Shape.php
on the samples folder. Thanks.


Reply to this email directly or view it on GitHub
#123 (comment).

/)_/)
( . . )
C(")(")

@ivanlanin
Copy link
Contributor

@jhfangying When you have time, please test this feature. When you confirm that it's working, please close this issue. Thanks.

@ivanlanin
Copy link
Contributor

@jhfangying Any news? Can we close this issue? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants