-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix dependencies to have 7.1 compatible build (#1228)
* add assertions in test methods without assertions * loosen dependencies so 7.0 & 7.1 builds can succeed * fix some scrutinizer errors * update release date
- Loading branch information
Showing
23 changed files
with
110 additions
and
113 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,35 @@ | ||
Issue tracker is **ONLY** used for reporting bugs. NO NEW FEATURE ACCEPTED! Use [stackoverflow](https://stackoverflow.com/questions/tagged/phpword) for supporting issues. | ||
This is: | ||
|
||
- [ ] a bug report | ||
- [ ] a feature request | ||
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpword) | ||
|
||
# Expected Behavior | ||
|
||
Please describe the behavior you are expecting. | ||
|
||
# Current Behavior | ||
### Current Behavior | ||
|
||
What is the current behavior? | ||
|
||
# Failure Information | ||
### Failure Information | ||
|
||
Please help provide information about the failure. | ||
|
||
## How to Reproduce | ||
### How to Reproduce | ||
|
||
Please provide a code sample that reproduces the issue. | ||
|
||
```php | ||
<?php | ||
require __DIR__ . '/vendor/autoload.php'; | ||
|
||
$phpWord = new \PhpOffice\PhpWord\PhpWord(); | ||
$section = $phpWord->addSection(); | ||
$section->... | ||
``` | ||
|
||
## Context | ||
### Context | ||
|
||
* PHP version: | ||
* PHPWord version: 0.14 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,11 @@ | ||
# Description | ||
### Description | ||
|
||
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. | ||
|
||
Fixes # (issue) | ||
|
||
# Checklist: | ||
### Checklist: | ||
|
||
- [ ] I have commented my code, particularly in hard-to-understand areas | ||
- [ ] I have run phpunit, phpcs, php-cs-fixer, phpmd | ||
- [ ] I have run `composer check` and no errors were reported | ||
- [ ] The new code is covered by unit tests | ||
- [ ] I have update the documentation to describe the changes |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
b614497
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
KUDOS! 👍
After a year and a half @troosan I can kiss you! Thanks for this. Now I don't have to use my fork! And download 300MB plus of composer stuff.
Owe you a beer buddy! When you in Cape Town ;)
Regards.
JJ