Improve qmail support #39
Labels
Comments
jrfnl
added a commit
to jrfnl/PHPMailer
that referenced
this issue
Jun 20, 2021
From the PHP 8.1 changelog: > `htmlspecialchars()`, `htmlentities()`, `htmlspecialchars_decode()`, >` html_entity_decode()` and `get_html_translation_table()` now use > `ENT_QUOTES | ENT_SUBSTITUTE` rather than `ENT_COMPAT` by default. This means > that `'` is escaped to `&PHPMailer#39;` while previously it was left alone. > Additionally, malformed UTF-8 will be replaced by a Unicode substitution > character, instead of resulting in an empty string. Ref: https://github.com/php/php-src/blob/28a1a6be0873a109cb02ba32784bf046b87a02e4/UPGRADING#L149-L154 If effect this means that the output of the above mentioned functions may be different depending on the PHP version and the passed text string, unless the `$flags` parameter is explicitly passed. This patch proposes to add the old default to the one affected function call in PHPMailer, though most other flag combination choices would be just as valid, as long as a `$flags` parameter is passed. Ref: https://www.php.net/manual/en/function.htmlspecialchars.php
Synchro
pushed a commit
that referenced
this issue
Jun 22, 2021
From the PHP 8.1 changelog: > `htmlspecialchars()`, `htmlentities()`, `htmlspecialchars_decode()`, >` html_entity_decode()` and `get_html_translation_table()` now use > `ENT_QUOTES | ENT_SUBSTITUTE` rather than `ENT_COMPAT` by default. This means > that `'` is escaped to `'` while previously it was left alone. > Additionally, malformed UTF-8 will be replaced by a Unicode substitution > character, instead of resulting in an empty string. Ref: https://github.com/php/php-src/blob/28a1a6be0873a109cb02ba32784bf046b87a02e4/UPGRADING#L149-L154 If effect this means that the output of the above mentioned functions may be different depending on the PHP version and the passed text string, unless the `$flags` parameter is explicitly passed. This patch proposes to add the old default to the one affected function call in PHPMailer, though most other flag combination choices would be just as valid, as long as a `$flags` parameter is passed. Ref: https://www.php.net/manual/en/function.htmlspecialchars.php Co-authored-by: jrfnl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some parts of PHPMailer do not play nice with qmail, particularly its implementation of sendmail (in qmail-inject) as it's incompatible with some of the command line switches used by PHPMailer.
I've already implemented some of it in this branch, upgrading qmail to a whole new Mailer type rather than treating it as a flavour of sendmail. It should be working, but it needs testing in a qmail environment before merging into trunk.
The text was updated successfully, but these errors were encountered: