Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix canonicalization defaults ('Unknown body canonicalization algorithm: '), fixes #10 #17

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

geek-merlin
Copy link

Canonicalization algorithm "simple" must be interpreted as "simple/simple".
According to the RFC:

rfc4871-dkimbase.html#dkim-sig-hdr
rfc6376#section-3.5
..If only one algorithm is named, that algorithm is used for the header and "simple" is used for the body. For example, "c=relaxed" is treated the same as "c=relaxed/simple"...

I had a validaton error with a rapidmail newsletter due to this.

This trivial PR fixes the issue for me.

@geek-merlin
Copy link
Author

OK, the dev branch seems broken, here's for convenience the patch file for 0.3.
fix-canonicalization-defaults-for-phpmailer-dkimvalidator-0-3.patch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant