Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portrait plot annotate text color #999

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Portrait plot annotate text color #999

merged 3 commits into from
Nov 9, 2023

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Nov 8, 2023

Add flexibility in selecting color for annotation text in portrait plots

@lee1043 lee1043 linked an issue Nov 8, 2023 that may be closed by this pull request
[Feature]: portrait plot annotation text color #998
Closed
@lee1043 lee1043 self-assigned this Nov 8, 2023
@lee1043 lee1043 requested a review from bosup November 8, 2023 23:51
bosup
bosup approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@bosup bosup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This newly added option is very useful, especially for sequential color maps.

@lee1043 lee1043 marked this pull request as ready for review November 9, 2023 00:03
@lee1043 lee1043 merged commit 26326e5 into main Nov 9, 2023
5 checks passed
@lee1043 lee1043 deleted the portrait_plot_annotate_text_color branch November 9, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosup bosup bosup approved these changes

Assignees

@lee1043 lee1043

Labels
feature request graphic New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: portrait plot annotation text color
2 participants
@lee1043 @bosup