Update .pre-commit-config.yaml #991
Conversation
Update isort version and repo
Remove node setup and node-version
Add env
tomvothecoder
force-pushed
the
lee1043-patch-1
branch
from
a88a8d4
to
7e6bbe8
Compare
| @@ -1,6 +1,6 @@ | |||
| # Configuration file for `pre-commit` tool. | |||
| # Source: https://pre-commit.com/#pre-commit-configyaml---top-level | |||
| exclude: "docs|node_modules|migrations|.git|.tox|.md|sample_setups/(external-setups|jsons)|tests/deprecated" | |||
| exclude: "docs|node_modules|migrations|.git|.tox|README.md|sample_setups/(external-setups|jsons)|tests/deprecated" | |||
There was a problem hiding this comment.
@lee1043 and @acordonez, I isolated the issue of pre-commit skipping files to the .md substring in the exclude config. I'm not sure if pre-commit can handle file extensions or not (.tox is a not a file extension). I tried quickly Googling but didn't find any results.
I updated .md to README.md and now pre-commit runs locally and on CI/CD. Now pre-commit run --all-files picks up some issues that need to be fixed.
Let me know if pre-commit is working for you locally as well.
There was a problem hiding this comment.
@tomvothecoder this is also working locally for me now when I run pre-commit run --all-files. Thanks for looking into this!
There was a problem hiding this comment.
@tomvothecoder thank you very much for figuring this out! At some point I added .md assuming it was for file extensions because I was annoyed by pre-commit complaining for extra space at the end of line in .md files. My bad. I appreciate you figured this out!
There was a problem hiding this comment.
@acordonez and @lee1043 great and no problem!
Feel free to merge after you fix the new pre-commit issues. You can rebase your dev branches on the latest main to get pre-commit working again.
pyproject.toml
Outdated
| ignore_missing_imports = true | ||
| warn_unused_ignores = true | ||
| warn_redundant_casts = true | ||
| warn_unused_configs = true |
There was a problem hiding this comment.
I moved most configs from setup.cfg to pyproject.toml because pyproject.toml is a more modern standard.
| @@ -9,6 +9,10 @@ on: | |||
|
|
|||
| workflow_dispatch: | |||
|
|
|||
| env: | |||
| CANCEL_OTHERS: true | |||
| PATHS_IGNORE: '["**/README.rst", "**/docs/**", "**/ISSUE_TEMPLATE/**", "**/pull_request_template.md", "**/.vscode/**"]' | |||
There was a problem hiding this comment.
| PATHS_IGNORE: '["**/README.rst", "**/docs/**", "**/ISSUE_TEMPLATE/**", "**/pull_request_template.md", "**/.vscode/**"]' | |
| PATHS_IGNORE: '["**/README.md "**/docs/**", "**/ISSUE_TEMPLATE/**", "**/pull_request_template.md", "**/.vscode/**"]' |
Update black version and isort repo following the xcdat (https://github.com/xCDAT/xcdat/blob/main/.pre-commit-config.yaml)