Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mean climate 3d field vertical coordinate QC #978

Merged
merged 13 commits into from
Sep 19, 2023

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Aug 30, 2023

Mean climate 3d field vertical coordinate QC

  • pressure coordinate check
  • unit check
  • layer key check

@lee1043 lee1043 self-assigned this Aug 30, 2023
@lee1043 lee1043 linked an issue Aug 30, 2023 that may be closed by this pull request
@lee1043 lee1043 added New feature QC Quality Control labels Aug 30, 2023
@lee1043 lee1043 marked this pull request as ready for review September 19, 2023 02:28
@lee1043
Copy link
Contributor Author

lee1043 commented Sep 19, 2023

@acordonez when you get a chance, could you help checking if this PR makes any affect to the mean climate demo? No affect is expected but wanted to double check.

@acordonez
Copy link
Collaborator

@lee1043 Yes I'll test this out today

@acordonez
Copy link
Collaborator

@lee1043 The mean climate notebook 1b still runs with no errors. I did a before/after comparison for the Example 5 which uses zg_500 and am seeing some small (hundreths to thousandths place) differences in some of the metrics, for example rmsc_xy. It sounds like that is expected from this change?

@gleckler1
Copy link
Contributor

@acordonez @lee1043 Acceptable discrepancies for zg I think. You might compare with ta which in degrees C will be more intuitive.

@lee1043
Copy link
Contributor Author

lee1043 commented Sep 19, 2023

@acordonez thank you for checking this. @gleckler1 good point! I don't think we have obs for ta-850 in demo dataset, but I have compared to previously calculated from the PMP output database, and the difference is pretty subtle and I am confident on the consistency.

@lee1043 lee1043 merged commit f9dd510 into main Sep 19, 2023
5 checks passed
@lee1043 lee1043 deleted the mean_clim_3d_field_vertical_coord_unit_check branch September 19, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature QC Quality Control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical level extraction issue
3 participants