Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use xml open capability from pmp instead of xcdat #934

Merged
merged 1 commit into from
Jun 13, 2023
Merged

use xml open capability from pmp instead of xcdat #934

merged 1 commit into from
Jun 13, 2023

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Jun 7, 2023

No description provided.

@lee1043 lee1043 requested a review from acordonez June 10, 2023 02:25
@lee1043 lee1043 marked this pull request as ready for review June 10, 2023 02:25
@lee1043
Copy link
Contributor Author

lee1043 commented Jun 10, 2023 •
edited
Loading

@acordonez I found this has no impact, but would you mind double checking with mean climate demo in your env when you have time?

acordonez
acordonez approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes worked for me in the mean climate notebook.

@lee1043
Copy link
Contributor Author

lee1043 commented Jun 13, 2023

@acordonez thanks for checking!

@lee1043 lee1043 merged commit 4561314 into main Jun 13, 2023
3 checks passed
@lee1043 lee1043 self-assigned this Jun 21, 2023
@lee1043 lee1043 deleted the xml_open branch June 21, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acordonez acordonez acordonez approved these changes

Assignees

@lee1043 lee1043

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lee1043 @acordonez