Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mean clim patch #920

Merged
merged 19 commits into from
Apr 16, 2023
Merged

Mean clim patch #920

merged 19 commits into from
Apr 16, 2023

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Apr 7, 2023 •
edited

More flexibility in mean climate usage:

  • If variable name is different in filename and actual data array
  • Parallel coordinate plot vertical axis range -- allow median or mean as middle, allow user give specific value for max/min of vertical axes
  • Add more metadata in JSON

@lee1043 lee1043 marked this pull request as draft April 7, 2023 08:17
@lee1043 lee1043 self-assigned this Apr 15, 2023
@lee1043 lee1043 added this to the 3.0.3 milestone Apr 15, 2023
gleckler1
gleckler1 reviewed Apr 15, 2023
View reviewed changes
Copy link
Contributor

@gleckler1 gleckler1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lee1043 lee1043 marked this pull request as ready for review April 16, 2023 03:20
@lee1043 lee1043 merged commit 3b09852 into main Apr 16, 2023
3 checks passed
@lee1043 lee1043 deleted the mean_clim_patch branch April 16, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gleckler1 gleckler1 gleckler1 left review comments

Assignees

@lee1043 lee1043

Labels
bug enhancement
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lee1043 @gleckler1