910 pjg computeclimopts #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gleckler1 I'll run the compute_climatologies notebook just to do some regression testing for pcmdi_metrics/mean_climate/pcmdi_compute_climatologies.py. |
minor change for pre-commit checking
minor change for pre-commit test
minor change for pre-commit test
|
@lee1043 any hints regarding when these simple additions can be added? ;-) |
|
@gleckler1 sorry for the delay. I will check this and merge it today. |
lee1043
approved these changes
Mar 29, 2023
|
@gleckler1 just merged! |
|
@lee1043 Great, thank you! I'll take it for a spin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lee1043 @acordonez I'm sure there is a cleaner way to do this but these options are now functional. OK to overhaul as needed! The first option enables removing the clim period from the file name (useful, e.g., when clim is based on the entire time series period which is already part of the filename). The second option is to modify the default clim output list. Parameter file I have tested this with: https://github.com/PCMDI/obs4MIPs-cmor-tables/blob/230_clims_pjg/inputs/pcmdi/mkClims/test_obs_param.py
You probably don't have permission to write to obs4MIPs database so if you want to test this you probably need to change output path.