Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Contributors #907

Merged
merged 28 commits into from
Mar 3, 2023
Merged

All Contributors #907

merged 28 commits into from
Mar 3, 2023

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Mar 2, 2023

Apply All Contributors following their instruction to recognize all contributors in the README file.

@lee1043
Copy link
Contributor Author

lee1043 commented Mar 2, 2023

@all-contributors generate

@allcontributors
Copy link
Contributor

@lee1043

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@lee1043
Copy link
Contributor Author

lee1043 commented Mar 2, 2023

@all-contributors add @lee1043

@allcontributors
Copy link
Contributor

@lee1043

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@lee1043
Copy link
Contributor Author

lee1043 commented Mar 2, 2023

@all-contributors add @lee1043 code

@lee1043
Copy link
Contributor Author

lee1043 commented Mar 2, 2023

@all-contributors please add @lee1043 for code

@allcontributors
Copy link
Contributor

@lee1043

I've put up a pull request to add @lee1043! 🎉

@lee1043
Copy link
Contributor Author

lee1043 commented Mar 2, 2023

@allcontributors
Copy link
Contributor

@lee1043

I've put up a pull request to add @lee1043! 🎉

@lee1043 lee1043 linked an issue Mar 2, 2023 that may be closed by this pull request
@lee1043
Copy link
Contributor Author

lee1043 commented Mar 3, 2023

Updated README with new contributor list will look like this.

@lee1043 lee1043 marked this pull request as ready for review March 3, 2023 01:03
@lee1043
Copy link
Contributor Author

lee1043 commented Mar 3, 2023

@lee1043 lee1043 requested a review from acordonez March 3, 2023 01:34
Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Jiwoo!

@lee1043 lee1043 merged commit e0605b8 into main Mar 3, 2023
@lee1043 lee1043 deleted the all-contributor branch March 3, 2023 16:49
@tomvothecoder
Copy link
Collaborator

This is a cool repo extension. Thanks for the recognition Jiwoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README to reflect 3.0 release
3 participants