Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for MJO metrics #898

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Bug fix for MJO metrics #898

merged 1 commit into from
Feb 21, 2023

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Feb 21, 2023

To prevent a warning sign like below:
warning: failed for GISS-E2-H r1i1p1 module 'MV2' has no attribute 'float'

acordonez
acordonez approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me! I was also able to reproduce the original error in the jupyter notebook, and can confirm that this fixes the error.

@lee1043 lee1043 mentioned this pull request Feb 21, 2023
Closed
@lee1043 lee1043 linked an issue Feb 21, 2023 that may be closed by this pull request
Minor bug fix for MJO metrics #899
Closed
@lee1043 lee1043 merged commit fc99e5a into main Feb 21, 2023
@lee1043 lee1043 deleted the mjo_bugfix_patch branch February 21, 2023 21:54
@lee1043 lee1043 self-assigned this Feb 21, 2023
@lee1043 lee1043 added the bug label Feb 21, 2023
@lee1043 lee1043 added this to the 3.0 milestone Feb 21, 2023
lee1043 added a commit that referenced this pull request Apr 17, 2023
@lee1043
bug fix related to PR #898
ef8e409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acordonez acordonez acordonez approved these changes

Assignees

@lee1043 lee1043

Labels
bug
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Minor bug fix for MJO metrics
2 participants
@lee1043 @acordonez