Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portrait plotting code upgrade #875

Merged
merged 7 commits into from
Oct 11, 2022
Merged

Portrait plotting code upgrade #875

merged 7 commits into from
Oct 11, 2022

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Oct 9, 2022

Enable more flexibility and update examples to use latest PMP mean climate output

@lee1043 lee1043 marked this pull request as ready for review October 9, 2022 00:22
@lee1043
Copy link
Contributor Author

lee1043 commented Oct 10, 2022

@acordonez I think this PR is ready, which should only impact to the portrait plot examples in the jupyter notebook. In this PR I updated mean climate output to the latest, and added some options that would help more customization for the portrait plot. Would you mind re-running the update notebooks in the pcmdi_metrics/graphics/portrait_plot directory and see if they run without any problem?

@acordonez
Copy link
Collaborator

@lee1043 I gave all the notebooks in the portrait_plot folder a run, and they are all working out-of-the-box.

@lee1043
Copy link
Contributor Author

lee1043 commented Oct 11, 2022

@acordonez Excellent! Thank you for checking them. Could you approve the changes in the review?

@lee1043 lee1043 merged commit 02921b6 into main Oct 11, 2022
@lee1043 lee1043 deleted the ljw_portrait branch October 11, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants