Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Mapping function from collections.abc to comply with Python 3.10 #854

Merged
merged 4 commits into from
Jun 10, 2022

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Jun 9, 2022

To be python 3.10 compliance Mapping function should be imported from collections.abc instead collections, following the discussion from conda-forge/pcmdi_metrics-feedstock#6 (comment)

@lee1043 lee1043 self-assigned this Jun 9, 2022
@lee1043 lee1043 requested a review from acordonez June 9, 2022 23:26
@lee1043 lee1043 added the bug label Jun 9, 2022
@lee1043 lee1043 changed the title Update base.py Import Mapping function from collections.abc to comply with Python 3.10 Jun 9, 2022
Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed this in a fresh environment with Python=3.10 and ran the test "--help" commands for the major driver scripts. It looks like this import statement is working for me now.

@lee1043
Copy link
Contributor Author

lee1043 commented Jun 10, 2022

@acordonez Excellent, thank you for checking on it. Should we re-release v2.3 or do a new release as v2.3.1? I am fine with either, just wanted to check with you which would be easier in the release workflow?

@lee1043 lee1043 merged commit 4cd9f2b into main Jun 10, 2022
@lee1043 lee1043 deleted the lee1043-patch-1 branch June 10, 2022 00:16
@lee1043
Copy link
Contributor Author

lee1043 commented Jun 10, 2022

@acordonez I just released v2.3.1, could you please update feedstock?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants