-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mov notebook #852
Update mov notebook #852
Conversation
lee1043
commented
May 27, 2022
•
edited
Loading
edited
- Update Modes of Variability notebook and code
- Added feature:
- Add PDO in the notebook
- In case landmask of OBS not given but need to do landmask, use estimated landmask for OBS
…d mask was not given, use estimated land mask to extract SST from global ts
@msahn could you please take this notebook look and see if that makes sense to you? @acordonez could you please see if the new notebook is reproducible on your end? This will need to run the updated demo0 from this branch in advance. |
I have tested the notebook in Gates. In my test, an error appears in 3.2.1 Run Metircs. Below is the copy of the error message. It seem like the observation data (ts_mon_20CR_PCMDI_gn_187101-201212.nc) is not downloaded by the current Demo_0. After it is fixed, I will test the rest part of the notebook.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notebook ran successfully after I changed the date range in one of the result file names. I left some other suggestions, but changing this file name was the only roadblock issue.
@msahn Did you run Demo 0 again in this branch? I was able to get the new obs data just now using Demo 0. |
Yes, I ran Demo 0 in this branch. Below is the list of OBS data downloaded. The list does not include "obs4MIPs_PCMDI_monthly/NOAA-ESRL-PSD/20CR/mon/ts/gn/v20210727/ts_mon_20CR_PCMDI_gn_187101-201212.nc" that is needed for PDO.
|
@msahn That is strange that the 20CR ts file was not there. But I see @acordonez is this file also downloaded on your end? |
@acordonez thanks for noticing that. Maybe I was having the old set too. Thanks @msahn for spotting it out. I will update the MoV notebook to use HadSST for PDO's reference dataset -- which is even better because in that way it is consistent to the reference paper. |
Change PDO reference ddataset to HadISST from 20CR
@msahn I was able to run conda and jupyter notebook on my LOFT laptop so have updated the notebook to use HadISST for PDO. Could you check if the notebook work as expected? |
I have tested the notebook again on Gates. Now it is working well! I think the notebook is very well organized, so it would be very useful documentation. I have a minor suggestion as below. |
@msahn that's an excellent news! Thanks for checking it.
@msahn great suggestion, added. |