Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taylor Diagram notebook #849

Merged
merged 5 commits into from
May 13, 2022
Merged

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented May 11, 2022

Notebook for generating Taylor Diagrams for multiple CMIPs using PMP archived results.

@lee1043 lee1043 self-assigned this May 11, 2022
@lee1043 lee1043 added this to the 2.3 milestone May 11, 2022
@lee1043 lee1043 marked this pull request as ready for review May 13, 2022 16:50
@lee1043 lee1043 requested a review from acordonez May 13, 2022 16:50
@lee1043
Copy link
Contributor Author

lee1043 commented May 13, 2022

@acordonez Could you please help verifying the new notebook from this PR when you have time?

Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lee1043 The notebook ran successfully for me. I wanted to flag that there were a couple of slight differences in the marker display order in Plot example 1 for me (different squares in front or back), but when I zoom in it does look like the correct data is present. The legends were exactly the same. I attached screen grabs. There were no differences in plot example 2.
Taylor_diagram_anas_run
Taylor_diagram_original
.

@lee1043
Copy link
Contributor Author

lee1043 commented May 13, 2022

@acordonez excellent, thank you!

@lee1043 lee1043 merged commit 0ba0094 into PCMDI:main May 13, 2022
@lee1043 lee1043 deleted the taylor_diagram_multi_mips branch May 13, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants