Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taylor Diagram #846

Merged
merged 8 commits into from
May 3, 2022
Merged

Taylor Diagram #846

merged 8 commits into from
May 3, 2022

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented May 2, 2022

Add generation of Taylor Diagram in graphic notebooks

@lee1043 lee1043 added this to the 2.3 milestone May 3, 2022
@lee1043 lee1043 self-assigned this May 3, 2022
@lee1043 lee1043 marked this pull request as ready for review May 3, 2022 19:28
@lee1043 lee1043 requested a review from acordonez May 3, 2022 19:28
@lee1043 lee1043 marked this pull request as draft May 3, 2022 19:30
@lee1043 lee1043 marked this pull request as ready for review May 3, 2022 19:32
@lee1043
Copy link
Contributor Author

lee1043 commented May 3, 2022

@acordonez Could you please help verifying the notebook that newly have Taylor diagram at the end can be reproduced from your end?

Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook ran successfully and I verified that the plots matched yours.

@lee1043
Copy link
Contributor Author

lee1043 commented May 3, 2022

@acordonez excellent, thank you!

@lee1043 lee1043 merged commit 5adf579 into PCMDI:main May 3, 2022
@lee1043 lee1043 deleted the add_taylor_diagram branch May 3, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants