Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMIP5 and 6 comparing portrait and parallel coordinate plot #843

Merged
merged 17 commits into from
May 5, 2022

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Apr 21, 2022

Jupyter notebooks for creation of portrait and parallel coordinate plots for comparing CMIP5 and CMIP6 models.

@lee1043 lee1043 marked this pull request as draft April 21, 2022 05:42
@lee1043
Copy link
Contributor Author

lee1043 commented Apr 29, 2022

NOTE: Need to update to use Metrics class to simplify process in the notebook.

@lee1043 lee1043 marked this pull request as ready for review May 4, 2022 04:43
@lee1043 lee1043 self-assigned this May 4, 2022
@lee1043 lee1043 added this to the 2.3 milestone May 4, 2022
@lee1043 lee1043 marked this pull request as draft May 4, 2022 04:45
@lee1043 lee1043 requested a review from acordonez May 4, 2022 16:19
@lee1043 lee1043 marked this pull request as ready for review May 4, 2022 16:19
@lee1043
Copy link
Contributor Author

lee1043 commented May 4, 2022

@acordonez I think this PR is ready for review, could you verify notebooks are working well on your end too when you have time?

Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted my prior comment and reposting as a review - The notebooks worked for me. One thing I noticed is that I had some old files in my portrait_plot/json_files that hadn't downloaded correctly in a past test (contained 404 errors). This caused a failure in the portrait plot notebook until I removed the existing json_files folder and started from scratch. Would the notebook still give the correct results if users had old versions of the same data in json_files? Should the json_files be cleaned before running each time?

@lee1043
Copy link
Contributor Author

lee1043 commented May 4, 2022

@acordonez thank you for checking. I have assumed that user will run from scratch -- starting from downloading, but I see your point -- thanks for pointing it out. I might have to implement more elegant way of downloading, but I think that is for the next PR unless we find any quick solution.

@lee1043 lee1043 merged commit 674ac2f into PCMDI:main May 5, 2022
@lee1043 lee1043 deleted the plot_cmip5and6_compare branch May 5, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants