Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update portrait and parallel plot examples for mean climate #837

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Apr 6, 2022

Update portrait and parallel plot examples for mean climate to use archived raw json from https://github.com/PCMDI/pcmdi_metrics_results_archive, instead of tar.gz

@lee1043 lee1043 requested a review from acordonez April 6, 2022 17:34
@lee1043 lee1043 merged commit 47fd0a6 into PCMDI:main Apr 12, 2022
@lee1043 lee1043 deleted the update_portrait_plot branch April 12, 2022 17:42
@acordonez
Copy link
Collaborator

@lee1043 This got lost in my inbox! I saw it's merged so I'll pull main and give it a final test.

@lee1043
Copy link
Contributor Author

lee1043 commented Apr 12, 2022

@acordonez it was a small minor change only on notebook so I was thinking it may be good to go, but additional test is always appreciated! Thank you :)

@acordonez
Copy link
Collaborator

@lee1043 I get 404 Not Found errors for the JSON downloads in parallel_coordinate_plot_mean_clim.ipynb and portrait_plot_mean_clim.ipynb.
I was able to run the notebooks by changing the url text "https://raw.githubusercontent.com/PCMDI/pcmdi_metrics_results_archive/archive_raw_json/" to "https://raw.githubusercontent.com/PCMDI/pcmdi_metrics_results_archive/main/" in the download cell. Does that point to the right files?

@lee1043
Copy link
Contributor Author

lee1043 commented Apr 12, 2022

@acordonez thank you for checking! Yes, main is correct. I might missed to update notebook after I merge branch in the PMP result repo.

@lee1043
Copy link
Contributor Author

lee1043 commented Apr 12, 2022

@acordonez could you please upload your patched notebook via a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants