Address PR comments for 787 ljw pre commit hook compliant #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `pre_commit` to `dev.yml` - Update `mypy` `python_version=3.9` in `setup.cfg` - Remove `mypy` from `.pre-commit-config.yaml` - Workaround flake8 errors related to F821 undefined name
|
Removing mypy sounds reasonable at this moment because most of PMP code has been wrote with dynamic typing, instead of static typing as checked by mypy. |
|
@tomvothecoder thanks for adding placeholder for testing. I believe this corresponds to the task 5 of the note. |
lee1043
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the GH Actions build issues in PR #787.
Summary of Changes
Address QA Tool Issues
test_placeholder.pyto workaroundpytesterror code 5 (no tests ran)pre_committodev.ymlF821 undefined nameFIXME:placeholder comments in the futureConfiguration Updates
mypyfrom.pre-commit-config.yamlmypyissues since there is a learning curve with using the Python type system. Another issue can be opened to integratemypyif desired.mypyfor optional static type checking #795