Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ymal files to start from scratch #781

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Remove ymal files to start from scratch #781

merged 6 commits into from
Nov 1, 2021

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Oct 28, 2021

No description provided.

@lee1043 lee1043 changed the title remove ymal files to start from scratch Remove ymal files to start from scratch Oct 28, 2021
@acordonez
Copy link
Collaborator

@lee1043 had another thought - do we need the Makefile anymore if .circleci is gone?

@lee1043
Copy link
Contributor Author

lee1043 commented Nov 1, 2021

@acordonez Great point. I do not have good understanding of purpose of the Makefile. If it is certain that the Makefile has been only used with circle ci, I agree we can remove it. Do you know how Makefile have been used in the workflow?

@acordonez
Copy link
Collaborator

@lee1043 I searched for each of the targets in the Makefile (e.g. conda-rerender) in the repo and many of them don't show up outside the Makefile. The ones that do only show up in .circleci/config.yml. The CircleCI config also looks like the only place we use "make" commands in the repo. Based on that info, it looks like the Makefile is only used for the CircleCI workflows.

@lee1043 lee1043 marked this pull request as ready for review November 1, 2021 17:36
@lee1043
Copy link
Contributor Author

lee1043 commented Nov 1, 2021

@acordonez thanks for investigating. In this PR, I removed circle ci related files and added github action workflow initiative. I agree it may be easier if we merge this to master before we ask Tom and Jason to step in. I will merge it when you approve the changes.

@acordonez
Copy link
Collaborator

@lee1043 I don't see anything else that looks like it should be deleted.

Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lee1043 lee1043 merged commit 2f58e4b into master Nov 1, 2021
@lee1043 lee1043 deleted the 776_ljw_workflow branch November 1, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants