Bias bar chart branch revisit and clean up #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linked issue: #349 |
|
@acordonez could you please see if the notebook works well on your end? |
acordonez
requested changes
Oct 12, 2021
There was a problem hiding this comment.
After installing this branch, I'm getting an error in the jupyter notebook, in the first cell of the "2. Plot" section:
Traceback (most recent call last):
File "bar_chart.py", line 7, in
from pcmdi_metrics.graphics.bias_bar_chart import BarChart
ModuleNotFoundError: No module named 'pcmdi_metrics.graphics.bias_bar_chart'
|
@acordonez thank you for finding out the bug. I fixed it. |
acordonez
approved these changes
Oct 12, 2021
|
@acordonez many thanks for checking it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if one of old branches, 349 bias bar chart, could be still useful as a housekeeping effort.