Add calendar months to test JSONs and reactivate tests #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acordonez thanks for the fix! |
lee1043
approved these changes
Aug 12, 2021
acordonez
changed the title
|
@acordonez thank you for adding calendar months to the test json!!! This will put us back on track. One test pending, I'll merge once its done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I manually added the "CalendarMonths" key with an empty list to the reference JSONs used for testing the mean climate metrics. We currently do not check what is in the CalendarMonths list, so the empty list is sufficient to help the tests pass.
Testing: These files passed all the tests locally.
I pulled in branch 758_ljw_circleci_test_pause to reactivate the CircleCI tests in the CircleCI configuration file.